Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add rest of XML docs for relational layer #20838

Merged
merged 1 commit into from
May 5, 2020
Merged

Query: Add rest of XML docs for relational layer #20838

merged 1 commit into from
May 5, 2020

Conversation

smitpatel
Copy link
Member

No description provided.

@smitpatel smitpatel requested review from a team and ajcvickers May 5, 2020 06:09
ajcvickers
ajcvickers approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but please follow up on @AndriySvyryd on the breaking changes.

@smitpatel smitpatel merged commit 7793514 into master May 5, 2020
@smitpatel smitpatel deleted the smit/moredocs branch May 5, 2020 17:58
AndriySvyryd
AndriySvyryd reviewed May 5, 2020
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a single typo

@ajcvickers ajcvickers mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajones lajones lajones left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd left review comments

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smitpatel @ajcvickers @lajones @AndriySvyryd